Robin Sommer

Results 160 comments of Robin Sommer
trafficstars

Yes, I'll merge, thanks @fatemabw!

To record what we talked about earlier: Up to you on the experimental notes, I'd go ahead and remove them at this point, assuming that people had enough time to...

Moving to 4.1 because ALM is pushed as well out.

This is still gated on ALM, which is now seeing major revision before it will land. Bumping.

We are already *not* relying on the content-type header, but do file sniffing instead. Doing that for encoding as well would be consistent with that.

Only took a quick look here, but I think I can see having `to_string()` escape non-printable character automatically, but we'd need to see that all callers of the function indeed...

> Zeek (master and 4.1) corrupts extracted PE executable from an HTTP response if the request has a non-expected Content-Type. Looks like this comes from the specific content-type that's used...

Looks like we're running out of time here, so moving to 4.1.0.

I think this is something to revisit once we have the new network protocol code landed in Broker.

Note that this comes with a risk of a major performance degradation in case that it doesn't quite work yet under heavy load. I would suggest we either do more...