Robin Sommer

Results 160 comments of Robin Sommer
trafficstars

Could make it optional. But maybe this would be better reported through the new metrics API now, depending where we're going with existing stats in general.

@grigorescu what parts are you working on here?

Switching to a set of strings makes sense to me (cc: @Neverlord). Yeah, I'd go without the caching at first to get something in place and then we can see...

I'm thinking to introduce the concept of a `barrier` to the Spicy language: a mechanism to block processing until multiple parsers have all arrived at a certain point. `barrier` would...

> I benchmarked this with a big internal parser and the optimizations here make no measurable difference. Can you tell how much code is actually removed (independent of performance)? >...

> ```c++ > __location__("foo.spicy:131:2"); > (void()); > ``` We could add a narrow, pattern-based optimization to the C++ code generator to skip these directly. Same for `default();`; or, even better,...

Well, I'd expect some overhead for sure, it's putting it all items into a tree structure that needs management. I'm not sure how much overhead I would expect honestly but...

I'm seeing the same issue but only when I'm inside a `tmux` shell. Outside `tmux` it works fine.

@Wajihulhassan remind me what's the issue exactly, is it just a mismatching Broker version or is there something else preventing it from working with Zeek 4?

Generally nothing should be able to leak from a user's perspective. If it does, it's a bug either in Spicy, the plugin, or Zeek. For files and analyzer's, it's Zeek...