Robin Sommer

Results 160 comments of Robin Sommer
trafficstars

Why the reference on `string`? Is that on purpose or to try work around something not working? Should this instead be: ``` type X = unit(inout msg: string) { n...

With #1712, the recommended way now will be: ``` type X = unit(msg: string&) { n : uint8 { local s = "Parsed %d" % $$; *msg = s; }...

> A problem here is that while packet loss may be the initial trigger for this issue, this issue then causes high cpu usage, which causes more packet loss and...

Rebased on top of #1833, now using our new AST dependency tracking. Test suite still fails because of #1831.

With #1833 and #1834 merged, this is now rebased on `main`. Still not sure if we want this or not due to runtime performance concerns.

@dcleblanc Any chance to get this merged? Otherwise we'll switch to a permanent fork I guess.

I believe we have a conceptual challenge here in the way look-ahead operates. With a look-ahead rule, the parser has a set of choices in terms of input stream tokens...

> There are similar issues around `&parse-from` and likely `&parse-at` as well. I was wondering about that while I was writing my comment, and I'm not sure. The difference is...

#1722 now rejects the original code here. I also confirmed that `&parse-from` and `&parse-at` don't cause trouble.

The error message isn't great but it's correct to reject this: these constants/literals must be know at compile time, so parameters can't be supported.