Robin Sommer

Results 160 comments of Robin Sommer
trafficstars

This is using `strtoul` internally. The man page says `base` can be 36 max, so I think I'll just add a check for that cap.

Nevermind, we're doing this ourselves actually, but capping the `base` still seems like a reasonable approach to me.

Ok, reopening, but not yet convinced. :-) Can you give me a code example how this would be used?

I can reproduce with the short example. Current master gives: ``` printf "12\n" | ./bin/spicy-driver a.spicy Issue_210_illegal_instruction.cc:179:1: warning: control reaches end of non-void function } ^ 1 warning generated. free():...

Ack, it's pretty important. On the downside, this will need full control flow tracking, so it's a bit of work.

Not sure I like the syntax, because it still leaves the `&requires` at a place where semantically it doesn't seem right. Couple other ideas: ``` type X = unit(length: uint8)...

Good thought, I like that for units. I'm unsure if we'd do that for fields as well, or stay with the `&requires` there?

Conceptually, I'd say `Undef` would be the right thing to use here; it's meant to mean "something that we don't know anything more specific about". To distinguish it from "unset",...

Yeah, mulling over this a bit more, I prefer (3), too. Seems like some nice little magic to have, even if it's a bit odd to hardcode that one type....