Robin Sommer

Results 160 comments of Robin Sommer
trafficstars

`git pull --rebase` avoids the additional merge, but yeah, I get your point. I can see adding an option that suppresses mails without any diff content. Might be as simple...

(So `git pull --rebase` leads to conflicts, but `git pull` can do a clean merge here? Interesting.) Now I'm getting confused about what you'd like to keep exactly. That 2nd...

That patch should work, but it may be worth generalizing this a bit to make the subject generally configurable and then also replace the `emailprefix` option. E.g., `mailsubject=[git/${repo}] ${heads}: ${msg}`...

It's kind of the same, head is just the internal git terminology and technically a bit broader in meaning than branch (to me, at least :-). But I don't really...

No, a single email can refer to multiple branches. An email is per commit. If at the time git-notifier runs a new commit has become part of multiple branches already,...

Which Bro version is that, git master? It should work with 2.5 but master has some incompatible changes.

You need btest: https://www.bro.org/development/README.btest.html

Nice patch, thanks. Couple thoughts: - would be nice to have an offline version too that reads from a trace; that's better suited for testing than going through tcpreplay. -...

Yeah, quite heavy for sure in this case. Iirc, the main reason for this is supporting searching for more than a single byte. __hlt_bytes_find_byte_from looks only for a single byte....

Nice, thanks for measuring! Feel free to file a merge request. I'm a bit behind with with Spicy/HILTI stuff due to time constraints but will aim to take a closer...