Ruslan Shestopalyuk

Results 17 comments of Ruslan Shestopalyuk

Just have had a similar problem (that's what brought me here), also on Windows 7 x64. The default port 8000 was occupied by some other application (in my case NVidia...

Please check the output from failed CircleCI tests, there is at least one that I can see may be relevant (analyze_code/Check Formatting).

There is also `NativeModuleArrayTypeAnnotation` that is still imported, but all the usages were removed in your diff :)

@Kudo, this (understandably) got a bit of pushback internally, as with this change we effectively make many more things public (and, as @alanleedev noted, not read-only anymore). Can we work...

@timgates42 I believe this required a follow-up, please rebase on main and resolve the following: * RCTBlockGuard.h was moved to `ReactCommon/react/nativemodule/core/platform/ios/ReactCommon/RCTBlockGuard.h` * The changes in `Libraries/Renderer/implementations/ReactFabric-dev.js` and `Libraries/Renderer/implementations/ReactNativeRenderer-dev.js` files are...

@timgates42 Are you planning to follow up on this? Otherwise, should we maybe close it?

> as it was not merged correctly What exactly was the problem, could you provide more context?

> > What exactly was the problem, could you provide more context? > > @rshest, After you imported the PR internally, I pushed some changes to address CI issues. However,...

@abdennour-jebbar-nw Thank you so much for taking this on! Looks good overall, aside from a few stylistic suggestions.

Hey @abdennour-jebbar-nw , what are your plans with the diff? Will you be able to follow up, or should we maybe close it?