react-native icon indicating copy to clipboard operation
react-native copied to clipboard

docs: Fix a few typos

Open timgates42 opened this issue 1 year ago • 5 comments

There are small typos in:

  • Libraries/Core/setUpTimers.js
  • Libraries/LogBox/Data/LogBoxData.js
  • Libraries/Pressability/Pressability.js
  • Libraries/Renderer/implementations/ReactFabric-dev.js
  • Libraries/Renderer/implementations/ReactNativeRenderer-dev.js
  • ReactCommon/react/nativemodule/core/platform/ios/RCTBlockGuard.h

Fixes:

  • Should read snapshot rather than snapsho.
  • Should read symbolication rather than sybolication.
  • Should read polyfilled rather than polyfiled.
  • Should read instance rather than instace.
  • Should read gesture rather than gestute.

Semi-automated pull request generated by https://github.com/timgates42/meticulous/blob/master/docs/NOTE.md

timgates42 avatar Mar 04 '23 23:03 timgates42

Fails
:no_entry_sign:

:clipboard: Missing Changelog - Can you add a Changelog? To do so, add a "## Changelog" section to your PR description. A changelog entry has the following format: [CATEGORY] [TYPE] - Message.

CATEGORY may be:
  • General
  • iOS
  • Android
  • JavaScript
  • Internal (for changes that do not need to be called out in the release notes)

TYPE may be:

  • Added, for new features.
  • Changed, for changes in existing functionality.
  • Deprecated, for soon-to-be removed features.
  • Removed, for now removed features.
  • Fixed, for any bug fixes.
  • Security, in case of vulnerabilities.

MESSAGE may answer "what and why" on a feature level. Use this to briefly tell React Native users about notable changes.

Warnings
:warning: :clipboard: Missing Summary - Can you add a Summary? To do so, add a "## Summary" section to your PR description. This is a good place to explain the motivation for making this change.
:warning: :clipboard: Missing Test Plan - Can you add a Test Plan? To do so, add a "## Test Plan" section to your PR description. A Test Plan lets us know how these changes were tested.

Generated by :no_entry_sign: dangerJS against 249287e81410d2521331261b3c7e622eac79182a

github-actions[bot] avatar Mar 04 '23 23:03 github-actions[bot]

Platform Engine Arch Size (bytes) Diff
android hermes arm64-v8a 8,518,342 +55
android hermes armeabi-v7a 7,834,102 -41
android hermes x86 8,998,442 -6
android hermes x86_64 8,853,537 +0
android jsc arm64-v8a 9,141,621 +0
android jsc armeabi-v7a 8,333,498 +0
android jsc x86 9,196,419 +0
android jsc x86_64 9,454,250 +0

Base commit: 379d9d4918886e002d70dd30fff29f8e6a8cf48f Branch: main

analysis-bot avatar Mar 05 '23 00:03 analysis-bot

@rshest has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

facebook-github-bot avatar Mar 05 '23 00:03 facebook-github-bot

Platform Engine Arch Size (bytes) Diff
ios - universal n/a --

Base commit: 947751fbe4fd72c67538260df0136a2e184bb4fb Branch: main

analysis-bot avatar Mar 05 '23 00:03 analysis-bot

@timgates42 I believe this required a follow-up, please rebase on main and resolve the following:

  • RCTBlockGuard.h was moved to ReactCommon/react/nativemodule/core/platform/ios/ReactCommon/RCTBlockGuard.h
  • The changes in Libraries/Renderer/implementations/ReactFabric-dev.js and Libraries/Renderer/implementations/ReactNativeRenderer-dev.js files are not useful, as the files are generated. The change should be done in ReactFiberHooks.js instead, which is the source file for those

Sending back to you to handle this. Thanks!

rshest avatar Mar 06 '23 10:03 rshest

@timgates42 Are you planning to follow up on this? Otherwise, should we maybe close it?

rshest avatar Mar 14 '23 10:03 rshest

oh sure sorry missed the request

timgates42 avatar Mar 16 '23 23:03 timgates42

@rshest has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

facebook-github-bot avatar Mar 17 '23 10:03 facebook-github-bot

@rshest merged this pull request in facebook/react-native@342c0beafa2a9711ac4151914d96ac1356049e74.

facebook-github-bot avatar Mar 17 '23 16:03 facebook-github-bot