react-native icon indicating copy to clipboard operation
react-native copied to clipboard

[Codegen 129] add emitObjectProp in parser primitives

Open tarunrajput opened this issue 1 year ago • 5 comments

Summary:

This is a follow up PR to #37872 as it was not merged correctly.

Changelog:

[Internal][Changed]: Add emitObjectProp in parser primitives

Test Plan:

yarn test react-native-codegen

tarunrajput avatar Jun 15 '23 05:06 tarunrajput

as it was not merged correctly

What exactly was the problem, could you provide more context?

rshest avatar Jun 15 '23 05:06 rshest

@rshest has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

facebook-github-bot avatar Jun 15 '23 05:06 facebook-github-bot

What exactly was the problem, could you provide more context?

@rshest, After you imported the PR internally, I pushed some changes to address CI issues. However, these changes were not merged as it seems the PR needs to be re-imported.

tarunrajput avatar Jun 15 '23 05:06 tarunrajput

Platform Engine Arch Size (bytes) Diff
android hermes arm64-v8a 8,757,683 +0
android hermes armeabi-v7a 8,070,258 +1
android hermes x86 9,250,279 -1
android hermes x86_64 9,099,417 +0
android jsc arm64-v8a 9,318,829 +1
android jsc armeabi-v7a 8,508,736 -1
android jsc x86 9,382,320 +1
android jsc x86_64 9,635,566 +0

Base commit: 894b62ce90e3659e3aae866fd8a24b893569b3db Branch: main

analysis-bot avatar Jun 15 '23 06:06 analysis-bot

What exactly was the problem, could you provide more context?

@rshest, After you imported the PR internally, I pushed some changes to address CI issues. However, these changes were not merged as it seems the PR needs to be re-imported.

Ah, I see. Sorry for that!

Thanks for making it right.

rshest avatar Jun 15 '23 06:06 rshest

This pull request was successfully merged by @tarunrajput in 24f77074184390ce5d5ca50ab6af3d8bb2d59e77.

When will my fix make it into a release? | Upcoming Releases

github-actions[bot] avatar Jun 15 '23 18:06 github-actions[bot]