Extract the UnsupportedArrayElementTypeAnnotationParserError in its o…

[matiassalles99]

Summary

This PR is part of #34872 This PR extracts the UnsupportedArrayElementTypeAnnotationParserError in its own throwing function.

Changelog

[Internal] [Changed] - Extract the UnsupportedArrayElementTypeAnnotationParserError in its own throwing function

Test Plan

[github-actions[bot]]

	Warnings
:warning:	packages/react-native-codegen/src/parsers/typescript/modules/index.js#L16 - packages/react-native-codegen/src/parsers/typescript/modules/index.js line 16 – 'NativeModuleArrayTypeAnnotation' is defined but never used. (no-unused-vars)
:warning:	packages/react-native-codegen/src/parsers/typescript/modules/index.js#L58 - packages/react-native-codegen/src/parsers/typescript/modules/index.js line 58 – 'UnsupportedArrayElementTypeAnnotationParserError' is assigned a value but never used. (no-unused-vars)
:warning:	packages/react-native-codegen/src/parsers/typescript/modules/index.js#L59 - packages/react-native-codegen/src/parsers/typescript/modules/index.js line 59 – 'UnnamedFunctionParamParserError' is assigned a value but never used. (no-unused-vars)
:warning:	packages/react-native-codegen/src/parsers/typescript/modules/index.js#L74 - packages/react-native-codegen/src/parsers/typescript/modules/index.js line 74 – 'throwIfUnsupportedFunctionReturnTypeAnnotationParserError' is assigned a value but never used. (no-unused-vars)

Generated by :no_entry_sign: dangerJS against 7240471b6e7e3c4675e43961a88ba6eb74fa3ef8

[analysis-bot]

Platform	Engine	Arch	Size (bytes)	Diff
android	hermes	arm64-v8a	7,102,440	+0
android	hermes	armeabi-v7a	6,470,493	+0
android	hermes	x86	7,519,895	+0
android	hermes	x86_64	7,378,573	+0
android	jsc	arm64-v8a	8,967,309	+0
android	jsc	armeabi-v7a	7,698,152	+0
android	jsc	x86	9,029,418	+0
android	jsc	x86_64	9,507,263	+0

Base commit: 850f855eb67edfbf777b4bf89f8b6e8e884b853e Branch: main

[analysis-bot]

Platform	Engine	Arch	Size (bytes)	Diff
ios	-	universal	n/a	--

Base commit: 850f855eb67edfbf777b4bf89f8b6e8e884b853e Branch: main

[pull-bot]

PR build artifact for 40fa9cdb8540ba6a928d8a944f85b9d200333f27 is ready. To use, download tarball from "Artifacts" tab in this CircleCI job then run yarn add <path to tarball> in your React Native project.

[facebook-github-bot]

Hi @matiassalles99!

Thank you for your pull request and welcome to our community.

Action Required

In order to merge any pull request (code, docs, etc.), we require contributors to sign our Contributor License Agreement, and we don't seem to have one on file for you.

Process

In order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA.

Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with CLA signed. The tagging process may take up to 1 hour after signing. Please give it that time before contacting us about it.

If you have received this in error or have any questions, please contact us at [email protected]. Thanks!

[facebook-github-bot]

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Meta Open Source project. Thanks!

[pull-bot]

PR build artifact for 8aa0e5d6211a9e4ceaaa0abbd9566701ffccc985 is ready. To use, download tarball from "Artifacts" tab in this CircleCI job then run yarn add <path to tarball> in your React Native project.

[pull-bot]

PR build artifact for 5df9d384fcb337b409324ba82bf4576dc30b5c3a is ready. To use, download tarball from "Artifacts" tab in this CircleCI job then run yarn add <path to tarball> in your React Native project.

[pull-bot]

PR build artifact for 484a82789050707a5547ed64c1c043e819251230 is ready. To use, download tarball from "Artifacts" tab in this CircleCI job then run yarn add <path to tarball> in your React Native project.

[rshest]

Please check the output from failed CircleCI tests, there is at least one that I can see may be relevant (analyze_code/Check Formatting).

[pull-bot]

PR build artifact for cfa262d4131c1bd83439ba47e1b6fc13d4b1aeb9 is ready. To use, download tarball from "Artifacts" tab in this CircleCI job then run yarn add <path to tarball> in your React Native project.

[rshest]

There is also NativeModuleArrayTypeAnnotation that is still imported, but all the usages were removed in your diff :)

[cipolleschi]

@matiassalles99, could you please rebase onto main and take care of the conflicts? Thank you so much! :pray:

[gabrieldonadel]

any updates on this?

[matiassalles99]

Yes im going to tackle it tomorrow, sorry for the late reply I didn't have much time lately

[facebook-github-bot]

@rshest has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

[pull-bot]

PR build artifact for 63df7a7e062eefdfb963111a1b1e8a8a17adaced is ready. To use, download tarball from "Artifacts" tab in this CircleCI job then run yarn add <path to tarball> in your React Native project.

[matiassalles99]

@rshest Just fixed conflicts

[pull-bot]

PR build artifact for 7240471b6e7e3c4675e43961a88ba6eb74fa3ef8 is ready. To use, download tarball from "Artifacts" tab in this CircleCI job then run yarn add <path to tarball> in your React Native project.