Robert Herbig

Results 47 comments of Robert Herbig

> I've expanded the scope a bit, and went full hog removing includes, and adding all the prefixes I understand the desire to improve the script, but doing everything at...

> > > I've expanded the scope a bit, and went full hog removing includes, and adding all the prefixes > > > > > > I understand the desire...

As for the code itself, the changes look fine (assuming this is the direction we want to go). I would suggest adding a validator that detects overrides and warns that...

re: performance. I was wondering about that too. I suspect it'll be fine given how little what we do should stress a system, how short of a time most Flags...

@KatoakDR @MahtraDR @asechrest would one of you have time to review this PR?

> @rpherbig can probably grab one, I don't remember if I'm in the new org. You're an owner of the new org. That said, I don't see where to generate...

Thank you @KatoakDR ! Token DM'd to you for inclusion in the PR.

> We have over 1,700 tests on regex101, and we continually add more I'll take your word for testability! :) The code looks a lot more readable! Let me know...

I don't know much about research, but the code looks fine to me other than the few comments. ✔️