dr-scripts icon indicating copy to clipboard operation
dr-scripts copied to clipboard

[scripts] [pick] add autoloot support

Open Chewmatca opened this issue 3 years ago • 7 comments

  • added autolooting of box contents to save time picking out gems one at a time and coins. Alot faster boxing!
  • left unwanted items in boxes so they can be disposed of quicker rather than pulling them out one by one
  • users must add a autoloot_container: lootpouch etc to their YAML
  • user must set autoloot autobox to true, autoloot gems and autoloot coins with autoloot for it to work.

If its possible to pickup a lootcontainer label automatically from the match that would be ideal then nothing has to be added to YAMLS but wasnt sure how best to do that (maybe from the new flag regex?)

discord MattG.

Chewmatca avatar Feb 08 '22 07:02 Chewmatca

@KatoakDR @MahtraDR @asechrest would one of you have time to review this PR?

rpherbig avatar Feb 08 '22 15:02 rpherbig

@KatoakDR @MahtraDR @asechrest would one of you have time to review this PR?

Will do

KatoakDR avatar Feb 08 '22 16:02 KatoakDR

@KatoakDR @MahtraDR @asechrest would one of you have time to review this PR?

Will do

Been busy with dependency and drinfomon this week; this is still on my todo list to review

KatoakDR avatar Feb 09 '22 23:02 KatoakDR

@Chewmatca Wanted to thank you for contributing!

-Gildaren in Discord

asechrest avatar Feb 11 '22 05:02 asechrest

ok lol ive commited same file alot cause i kept messing up. have another look... PS it needs testing a bit wider it might toss good jank! Also if using a personal trash can this could be sped up a lot by emptying the can at the end of script rather than as it goes with tap then tap again or whatever the verb used is. Buuuut, as is its much faster using an autolooter. @KatoakDR

Chewmatca avatar Feb 11 '22 07:02 Chewmatca

I'm slowly pecking away at this PR to fix the outstanding comments. I have a pouch removing+swapping method I'll PR today. This is a very promising PR, and it speeds up box popping time considerably, so I'm keen to get the issues resolved.

MahtraDR avatar Jun 29 '22 21:06 MahtraDR

Having tested this quite a bit tonight, this isn't quite ready just yet. I'll keep pecking at it.

MahtraDR avatar Jul 02 '22 10:07 MahtraDR

@MahtraDR @Chewmatca Is this still being Worked on or still a necessity? I've used the lootsack automatic box stuff without issue. I'm not seeing the value add or the need/use of this honestly.

Kiriawen avatar Jan 16 '23 04:01 Kiriawen

Closing as abandoned.

MahtraDR avatar Mar 24 '23 22:03 MahtraDR