dr-scripts
dr-scripts copied to clipboard
[data] [base.yaml] Merge *_no_use_rooms into one list, and use anchors.
<pushBold/>Failed to activate due to room settings.<popBold/> <pushBold/>Recommend you add room number: 9639 to wand_watcher_no_use_rooms in your yaml.<popBold/>
You might want to add it to pattern_hues_no_use_rooms
as well.
You might want to add it to
pattern_hues_no_use_rooms
as well.
And probably to buff-watcher too. Should we maintain a common-list and just anchor it in?
You might want to add it to
pattern_hues_no_use_rooms
as well.And probably to buff-watcher too. Should we maintain a common-list and just anchor it in?
That would make maintaining easier.
You might want to add it to
pattern_hues_no_use_rooms
as well.And probably to buff-watcher too. Should we maintain a common-list and just anchor it in?
That would make maintaining easier.
See the current version. Whatcha think?
Looks good. Perhaps nothing, but I do
<< : *anchor
not<<: *anchor
.
They're both valid yaml. The important thing isn't the space, or the colon, but the <<
which is a merge key
@Kiriawen @BinuDR I'd love your feedback here. Having the lists all merged, makes things much simpler to maintain. There are place here where an almanac could be used, where the magic stuff doesn't work, but I reckon this is a reasonable compromise, and the almanac will get used as soon as they leave that room anyway.
Looks good. Perhaps nothing, but I do
<< : *anchor
not<<: *anchor
.They're both valid yaml. The important thing isn't the space, or the colon, but the
<<
which is a merge key
Again, just something we may want to standardize one.
As for the code itself, the changes look fine (assuming this is the direction we want to go). I would suggest adding a validator that detects overrides and warns that the defaults changed (or maybe even that the individual settings are deprecated...).