dr-scripts icon indicating copy to clipboard operation
dr-scripts copied to clipboard

[scripts] [theurgy] fix prayer mat, and use common-methods

Open MahtraDR opened this issue 3 years ago • 4 comments

Trying to pin down some prayer mat issues where my cleric is stuck with an unrolled mat, trying to leave, and can't.

Also noticed we didn't even call common-theurgy... This needs a proper cleanup/rewrite someday.

depends on https://github.com/rpherbig/dr-scripts/pull/5678

MahtraDR avatar Feb 27 '22 10:02 MahtraDR

I've expanded the scope a bit, and went full hog removing includes, and adding all the prefixes. I'll leave it running on my now-two clerics for a few days.

MahtraDR avatar Mar 20 '22 09:03 MahtraDR

I've expanded the scope a bit, and went full hog removing includes, and adding all the prefixes

I understand the desire to improve the script, but doing everything at once makes the review much harder

rpherbig avatar Mar 21 '22 00:03 rpherbig

I've expanded the scope a bit, and went full hog removing includes, and adding all the prefixes

I understand the desire to improve the script, but doing everything at once makes the review much harder

Fair enough. I can do one include at a time? What's a morsel size that is reasonably disgetible?

MahtraDR avatar Mar 21 '22 00:03 MahtraDR

I've expanded the scope a bit, and went full hog removing includes, and adding all the prefixes

I understand the desire to improve the script, but doing everything at once makes the review much harder

Fair enough. I can do one include at a time? What's a morsel size that is reasonably disgetible?

I'd even be fine with one PR for the common* changes and one for the real changes. To me, the difference is something fairly mechanical (common* changes) vs "interesting" (theurgy changes)

rpherbig avatar Mar 21 '22 13:03 rpherbig