Ricky O'Steen
Ricky O'Steen
> But nothing needed on this side, is that right? I'm pretty sure that's correct, still investigating the fix on our end.
@astrofrog It seems like at the point we get the `SubsetCreate` message, the subset hasn't finished propagating/being applied to all of the data - when I switched to subscribing to...
> @rosteen - I have now added some changes to make sure that we delay any subset creation or deletion messages until the subset has been defined or removed from...
> > @rosteen - I have now added some changes to make sure that we delay any subset creation or deletion messages until the subset has been defined or removed...
@rileythai I rebased this and am seeing test failures - would you double check against your local branch and make sure I didn't botch something in the rebase? This was...
I just talked to @keflavich about this offline - I'm pretty sure that the code to do this was always wrong anyway, since it was always using the spectral axis...
> Really thorough tests that should definitely improve coverage, though I do not envy the dev that has to update these tests in the future 😅 My first impression is...
> but why isn't this possible more generally? It's not that it isn't possible more generally, it's that we rely on `NDIOMixin` for the `read` method, so there's not (I...
I'm going to go ahead and merge this, we can follow up to extend this to other loaders if desired.
> I'm not sure if this is asking too much but can we get a release with this fix please? I'll try to get a release out later this week,...