Ricky O'Steen

I should have time to pull down the latest changes and think more about the knot question today. My initial thought is that while it would be nice to be...

@alexji I was thinking pretty much the same thing about auto-generating the N knots. @hcferguson would that solution fit with your needs? We'd certainly document what exactly specifying the number...

@jdavies-st @ibusko I'm still seeing `line_flux` and `equivalent_width` returning `NaN [unit]` on masked arrays after #670, can someone else test and see if they're getting the same result? I assume...

I'm using the `specviz` UI to define a subset around a line, then using `data = specviz.app.get_data_from_viewer("spectrum-viewer", 'Subset 1')` to retrieve the data via the `glue-astronomy` data translators (which I've...

The flux array is not all NaNs: ``` >>> flux[np.where(~mask)] >>> flux[np.where(~mask)].shape (255,) >>> np.nanmax(flux) ``` Edit: That said, if using regions is a workaround that all the analysis functions...

But your code snippet doesn't show that all the values are NaN, it shows that the first and last three values are NaN (which is expected, since the selected subset...

Haha, sorry - I was actively looking at/into this and caught your comment too quickly. I would argue (and this is getting into what the acceptance criteria for closing this...

Thanks @chloe-mt-cheng! I'll take a look at updating the failing tests, but these seem like sensible changes.

If you're looking for an interactive tool, I'd recommend checking out [Jdaviz](https://jdaviz.readthedocs.io/en/latest/), which includes a configuration (`Specviz`) for working with spectra that is based on specutils. Back to the issue...

@eteq @keflavich Some more detail on the exact cause of the slowdown: This is an IRAF file, which `Spectrum1D.read()` initializes from by creating a spectral_axis array and initializing the `Spectrum1D`...