Ricky O'Steen
Ricky O'Steen
Looks good to me too.
@Cadair Apologies for the extreme delay in replying to this, I've had a tab open with it haunting my conscience for months while hoping that maybe @eteq would pick up...
A couple things I noticed testing this: 1) Loading the 1D spectrum and then the 2D spectrum from the test leads to an error (` UnitConversionError: 'pix' and 'nm' (length)...
> Thanks! Would need a test and a change log as well. I wasn't 100% sure if this should count as an enhancement or a bug fix, and therefore what...
> Depends on what "even if format is specified" means? Does all the format support `xz` compression? 🤷 If you call for example `Spectrum1D.read('tabular_fits_file.fit.xz')`, the code in `registry.core` handles opening...
It seems like this did break a test, I'll look into it tomorrow.
Unfortunately, clearing that error (on test collection) revealed ~460 actual errors, so this isn't a trivial change and I don't currently have time to work through the farther-reaching implications. I'll...
> In the meantime, is it possible to workaround this problem for your specific use case over at https://github.com/astropy/specutils/blob/main/specutils/io/default_loaders/tabular_fits.py ? Yes, I just removed the `format` specification that was added...
> That is unfortunate. Do you want to close this PR without merge and open a bug report instead? We have a strict stale bot rule for PRs. I couldn't...
I opened #16760 as a follow-up to this since I was not able to see it to completion. Closing this PR.