specutils icon indicating copy to clipboard operation
specutils copied to clipboard

feat: SDSS-V (astra) model spectra default loader

Open rileythai opened this issue 1 year ago • 3 comments

This PR addresses #1183 , and adds a default loader for the model spectra from SDSS-V's astra with relevant tests.

rileythai avatar Dec 06 '24 04:12 rileythai

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 87.06%. Comparing base (dd1d60b) to head (21a5baa).

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1203      +/-   ##
==========================================
+ Coverage   86.90%   87.06%   +0.15%     
==========================================
  Files          63       63              
  Lines        4576     4645      +69     
==========================================
+ Hits         3977     4044      +67     
- Misses        599      601       +2     

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

codecov[bot] avatar Feb 11 '25 02:02 codecov[bot]

i forgot to mark this as ready 2 months ago, should be good now

rileythai avatar Feb 11 '25 02:02 rileythai

@rileythai I rebased this and am seeing test failures - would you double check against your local branch and make sure I didn't botch something in the rebase? This was originally from before the 2.0 release, so there certainly could be changes needed to get it up to date beyond what I did to resolve the conflicts. Apologies for missing this when you initially marked it ready for review!

rosteen avatar Aug 26 '25 18:08 rosteen