Ricky O'Steen
Ricky O'Steen
I was actually hoping to get an RC out by today to facilitate people testing 2.0, but I was still hoping to get @eteq's thumbs up on https://github.com/astropy/specutils/pull/1211. I may...
Can this be closed now that we're using Solara instead of Voila?
> But we assume it is flipped in the mouseover. You fixed the flipping but not mouseover code, but CI still passes. What does this mean? Well, for one, this...
> > look at something non-symmetric like (1, 2)? > > Yes, I think that is better. Thanks! I updated one of the mouseover tests to be sensitive to an...
Fixed that comment, I'll merge after tests pass.
Hmm, since there are no other bugfixes waiting to go out, I'll re-milestone to 4.0.
> lgtm, I just have implementation nitpicks. > > I think you need to add the expected units to the docstring, though. Alright, I addressed your comments, thanks for the...
Test failures are known and unrelated.
> I have time this weekend -- this should be a simple fix. Great - we just merged another bug fix, I can wait to do a bug fix release...
I have an internal ticket to add this, I'll bump it up in the priority queue.