rclcpp issues

Executer regression fix

1

Fixes https://github.com/ros2/rclcpp/issues/2508

Check for negative time in rclcpp::Time(int64_t nanoseconds, ...) constructor

rclcpp::Time currently allows a negative time when constructing with int64_t nanoseconds (but not with int32_t seconds even though both can possibly hold a negative value). For a more uniform interface...

sharminramli

fix(StaticSingleThreadedExecutor): Fixed regression in spin()

5

Fixes https://github.com/ros2/rclcpp/issues/2470

jmachowinski

Regression : Executor::spin_some_impl is active waiting

This was introduced in #2142 https://github.com/ros2/rclcpp/blob/3d58f0fb703d86461c2ab2fb39cd2640dc26e219/rclcpp/src/rclcpp/executor.cpp#L383 This condition make the executor active spin until the time is over if used in spin_all. I guess ```c++ if (!wait_result_.has_value() || !exhaustive) {...

jmachowinski

Throw on subscriber with incompatible QoS by default.

8

Printing a warning here is not enough as subscribers that want to get "latched" messages will never get ANY messages.

Zyrin

[wjwwood] feat(MultiThreadedExecutor): Added ability to handle exceptions from threads

8

Modified version of https://github.com/ros2/rclcpp/pull/2382

wjwwood

rclcpp::Time(int64_t nanoseconds, ...) should check for negative time

## Bug report **Required Info:** - Operating System: - Ubuntu 22.04 - Installation type: - binaries (apt) - Version or commit hash: - ros-iron-rclcpp/jammy,now 21.0.5-1jammy.20240213.155845 amd64 - DDS implementation: -...

sharminramli

Add support for spin_until_complete (take 2)

9

Reverts #1956, so it un-reverts #1874 (with some major updates), see https://github.com/ros2/rclcpp/pull/1874#issuecomment-1165811614 Replaces #1957 Closes #1821 This adds `spin_until_complete(condition, timeout)`. This also adds `rclcpp::Executor::spin_for(duration)`. Original Issue: #1821 (Added by @fujitatomoya)...

christophebedard