rclcpp icon indicating copy to clipboard operation
rclcpp copied to clipboard

Published 20 hours ago • verified publisher icon ros2

Executer regression fix

Open jmachowinski opened this issue 1 year ago • 1 comments
trafficstars

Fixes https://github.com/ros2/rclcpp/issues/2508

jmachowinski avatar Apr 17 '24 12:04 jmachowinski

CI:

  • Linux Build Status
  • Linux-aarch64 Build Status
  • Windows Build Status

fujitatomoya avatar Apr 17 '24 20:04 fujitatomoya

I looked further into this, as all the tests lid up. I pushed an updated version, can someone rerun the CI with this ?

@wjwwood @mjcarroll I noticed, that the spin_some_impl method did not act according to the documentation. It was not recollecting ready executables on every call. Is this intentional, or a bug ?

jmachowinski avatar Apr 19 '24 09:04 jmachowinski

@jmachowinski sorry i missed this, here is new CI.

CI:

  • Linux Build Status
  • Linux-aarch64 Build Status
  • Windows Build Status

fujitatomoya avatar Apr 25 '24 16:04 fujitatomoya

Closing in favor of https://github.com/ros2/rclcpp/pull/2517, but we can reopen this one if needed.

wjwwood avatar May 01 '24 11:05 wjwwood