Robert Nagy

Results 722 comments of Robert Nagy

To really get it spec compliant:ish we would need force gc at some interval? Or we could run out of socket handles.

> reader.read() is a blocking operation that waits until new data arrives or the stream ends > But if the server neither sends new data nor closes the connection, this...

`subarray` is quite slow. I've spent a lot of time removing sub array creation in node core due to this.

It super expensive to create typed arrays since it does a lot of checks. Creating a different abstraction is also an option. Internall we use something like this for creating...

Add another variable called fastNowAbsolute which is updated to date.now in every refresh

@metcoder95 do you think you could help me with a PR removing the interceptor stuff?

Added `Change hooks signature to accept objects instead of params.`

Regarding to what to do instead of interceptors. See the following example for nxt-undici https://github.com/nxtedition/nxt-undici/blob/main/lib/index.js#L116-L132

> Regarding interceptors: how would you implement them instead? ``` const dispatch = [ dispatch => (opts, handler) => dispatch(opts, new LogHandler(opts, { handler, dispatch })), dispatch => (opts, handler)...

> > ``` > > > const dispatch = [ > > > dispatch => (opts, handler) => dispatch(opts, new LogHandler(opts, { handler, dispatch })), > > > dispatch =>...