Robert Nagy comments

Results 722 comments of


                                            Robert Nagy

`Writable.write(buf, sourceOffset, sourceLength)`

I think this would need support in node core to be meaningful. The conversion into buffer happens in native code for many APIs.

`Writable.write(buf, sourceOffset, sourceLength)`

```js import { bench, run } from 'mitata' import { Writable } from 'node:stream' const w = new Writable({ write (chunk, encoding, callback) { callback() } }) const buf =...

`Writable.write(buf, sourceOffset, sourceLength)`

> Maybe it could be investigated if .subarray() or Uint8Array initialization could be made faster. I have looked into it and it's in V8. Nothing we can do as far...

`Writable.write(buf, sourceOffset, sourceLength)`

I will have a go at it if I ever have time.

Implement new nb_samples API for NTSC support

Hm, maybe I will have to check. Unfortunately this change was required in order to get channel and layer producer working properly.

Implement new nb_samples API for NTSC support

@TomKaltz @5opr4ni sorry, I accidentally uploaded incompatible ffmpeg dlls when updating scanner.exe. Should be fixed now.

Implement new nb_samples API for NTSC support

@5opr4ni NTSC should run now. Still has the 1 sample off each frame problem but so far I haven't been able to notice it.

Error: && can only immediately follow a statement

I'm guessing it doesn't like something here: ``` RUN set -ex \ # use pre-existing gpg directory, see https://github.com/nodejs/docker-node/pull/1895#issuecomment-1550389150 && export GNUPGHOME="$(mktemp -d)" \ && for key in \ 6A010C5166206594AA57F0A146CF1EEEFCA1237F5...

feat: convert_latin1_to_utf8_s

Not sure what else I have to do to make this pass CI... a little help?

interop broken

See https://github.com/nodejs/undici/pull/1782/commits/213cbfe3acda5d1723d57b92db52a8efb5ffd800