Robert Nagy comments

Results 722 comments of


                                            Robert Nagy

UV_USE_IO_URING does not update file handle position

I think we should throw in `fs.write` if `position` is not provided while `UV_USE_IO_URING` is enabled. Do we have any other such instances? `net`?

UV_USE_IO_URING does not update file handle position

@nodejs/tsc I think this is so bad that we should just remove `UV_USE_IO_URING` until we figure out a way to fix it.

UV_USE_IO_URING does not update file handle position

> Didn't we disable UV_USE_IO_URING by default everywhere? Yes, referring to a security issue. But some users like us enable it without knowing that here be dragons.

UV_USE_IO_URING does not update file handle position

They are sequential.

perf(fetch): avoid redundant conversion

I'm not maintaining the web stuff anymore but if I did, I would be against anything that deviates from spec due to maintenance overhead. @KhafraDev

Re-evaluating Node.js Experimental Features

- AsyncHooks: Is there any point in still having this as experimental? IMHO it's not like it's going to be removed. In practice we are treating it as stable. It...

Re-evaluating Node.js Experimental Features

> 1. mark async_hooks stable. I agree with this. However, are we good with that they don't work properly with esm? Or do they?

Exposing RE2::Set

Using `Set` is a 40x performance improvement for our use when we need to test a string against multiple (100+) regexes. Would suggest something like the following: ```js const set...

headersTimeout on Agent appears to be broken since 6.20.0

Du you have a full repro?

database is locked

Not sure when/how this can occur.