readable-stream icon indicating copy to clipboard operation
readable-stream copied to clipboard

interop broken

Open ronag opened this issue 3 years ago • 2 comments

In utils we use:

const kDestroyed = Symbol('kDestroyed') const kIsErrored = Symbol('kIsErrored') const kIsReadable = Symbol('kIsReadable') const kIsDisturbed = Symbol('kIsDisturbed')

But that means that using helper methods with node core stream will give incorrect results. I believe we need to also check the methods from 'stream'.

Alternatively change the core implementation to not use symbols...

ronag avatar Nov 25 '22 10:11 ronag

See https://github.com/nodejs/undici/pull/1782/commits/213cbfe3acda5d1723d57b92db52a8efb5ffd800

ronag avatar Nov 25 '22 10:11 ronag

Is there any way to get those Symbols out from Node.js core? If not, we should make some change there first.

mcollina avatar Nov 25 '22 11:11 mcollina