Roman Ivanov

upgrade to checkstyle 10.3.4

1

https://checkstyle.org/releasenotes.html#Release_10.3.4

Detected at https://github.com/checkstyle/checkstyle/pull/13928 code: ``` public Set getExternalResourceLocations() { return Stream.concat(filters.stream(), Stream.concat(ordinaryChecks.stream(), commentChecks.stream())) .filter(ExternalResourceHolder.class::isInstance) .map(ExternalResourceHolder.class::cast) .flatMap(resource -> resource.getExternalResourceLocations().stream()) .collect(Collectors.toSet()); } ``` mutation is: org.pitest.mutationtest.engine.gregor.mutators.experimental.NakedReceiverMutator replaced call to java/util/stream/Stream::map with receiver...

Remove '//ok' comments from Input files

68

After hundreds of example PR reviews, I , and not only I found that comment `ok` is just a noise that makes it hard to read. This example is small,...

update TokenTypes.java to new format of AST print

1

We need to update https://checkstyle.sourceforge.io/apidocs/com/puppycrawl/tools/checkstyle/api/TokenTypes.html to reflect the current printed abstract syntax tree representation. Example of old style (note the `+` and lack of `->`): ``` +--LITERAL_NEW (new) | +--LITERAL_FLOAT...

Update tests that use inner test Checks to use Input files with violation comments

8

Detected at https://github.com/checkstyle/checkstyle/pull/14237 But it is not first time I see usage of such inner in test Check that doesn't do violations but do some static collection update. We need...

Execute all checkstyle samples in each PR execution

11

we almost missed breaking compatibility at https://github.com/checkstyle/checkstyle/pull/12392#issuecomment-1367643842 we need to run all samples in our CI on each PR. we already did this for ant: https://github.com/checkstyle/checkstyle/blob/8a1f198526571c1c206f88b495047a4fcfd6764f/.semaphore/semaphore.yml#L54 https://github.com/checkstyle/checkstyle/blob/d3a5f9a5ba4a1f2df28900dd70f2204c92943521/.ci/no-exception-test.sh#L182 UPDATE: we leaked...

UnmodifiableCollectionUtil as created at https://github.com/checkstyle/checkstyle/pull/13127/files to bypass pitest issue mutation of unmodified collections. Pitest released a fix at https://github.com/hcoles/pitest/issues/1300 and we upgraded to the version of pitest at https://github.com/checkstyle/checkstyle/commit/68f7af17f6a0020a720745bdce2d19b7d8dab5c5 We...

Resolve CheckerFramework violations

3

CheckerFramework was applied to project in scope of https://github.com/checkstyle/checkstyle/issues/12164 in scope of this issue we need to fix violations that are reasonable. Here is suppression list https://github.com/checkstyle/checkstyle/tree/master/config/checker-framework-suppressions We need each...

update version of IDEA inspection engine Version: 2023.3.3

1

we have stable failure of inspection validation https://app.circleci.com/pipelines/github/checkstyle/checkstyle/23624/workflows/e04a197a-8172-4262-9fa3-de02579854c4/jobs/506740/artifacts [inspection-results/YAMLSchemaValidation.xml](https://output.circle-artifacts.com/output/job/ab162cce-e22e-4921-9f14-8dc473901855/artifacts/0/home/circleci/project/target/inspection-results/YAMLSchemaValidation.xml) ``` file://$PROJECT_DIR$/.github/workflows/site.yml 14 project Validation by JSON Schema Schema validation: Property 'name' is not allowed name: "Site" yaml 0 12 ```...

infra: try shallow mode for clone

3

by request https://github.com/checkstyle/contribution/pull/819#issuecomment-1887683306 shallow: https://app.circleci.com/pipelines/github/checkstyle/checkstyle?branch=pull%2F14261 full clone: https://app.circleci.com/pipelines/github/checkstyle/checkstyle?branch=master optimization in good for CI, it is about 10 seconds or more, but still good.