Roman Ivanov

it takes a while to run them, but if we want to release, we should be able to release. UT failures is very rare case due to fact that we...

java8: Demand types for lambda

1

Sources: http://docs.oracle.com/javase/tutorial/java/javaOO/methodreferences.html ``` Arrays.sort(rosterAsArray, (Person a, Person b) -> { return a.getBirthday().compareTo(b.getBirthday()); } ); ``` could be written as: ``` Arrays.sort(rosterAsArray, (a, b) -> { return a.getBirthday().compareTo(b.getBirthday()); } ); ```...

Enforce file size on Java inputs

45

From https://github.com/checkstyle/checkstyle/pull/11156#pullrequestreview-845293639 All suppressions can be resolved in separate PRs for each Check individually. Rationale: big input files a hard to review, hard to debug. All existing inputs are moved...

Update Tests to use new 'verifyXxxxxx' method or 'execute' that use inlined config in Input files

77

this is phase 2 of updates at https://github.com/checkstyle/checkstyle/issues/10390#issuecomment-1065935409 please see [related commit](https://github.com/checkstyle/checkstyle/commit/e77a62f2bffc200f9eb5b6702e6d3d3fc50d8ce8) to see how to update code and remove suppression line. Test need to be updated: - [x] FileSetCheckTest...

create validation of git status on Windows environments

2

we did update for all/most Linux buillds at https://github.com/checkstyle/checkstyle/pull/11815 we need same for windows hosts: Appveyor and Cirrus so we need cmd implementation of such validation.

remove exclude of ci/pitest-survival-check-xml.groovy from TC this should be done AFTER we migrate to file based TC config as prove that it works. https://teamcity.jetbrains.com/admin/editRunType.html?id=buildType:Checkstyle_IdeaInspectionsMaster&runnerId=RUNNER_415&cameFromUrl=%2Fadmin%2FeditBuildRunners.html%3Fid%3DbuildType%253ACheckstyle_IdeaInspectionsMaster%26init%3D1&cameFromTitle= 

detected at https://github.com/checkstyle/checkstyle/pull/11701/files ``` catch (final CheckstyleException ex) { // -@cs[IllegalInstantiation] SAXException is in the overriden // method signature throw new SAXException(ex); } ``` should be something like: ``` catch...

From https://github.com/checkstyle/checkstyle/pull/11739#issuecomment-1157245833

Travis execution of nondex is not failing when plugin is failed to even run

2

when nondex plugin did not run we mark build as passed, that created leak of failure to master. This failure doesn't show any `.nondex` folders not being created. Original PR...

deprecafed in 10.2 (april 2022) https://github.com/checkstyle/checkstyle/commit/f6a15cfb3c3c64d16c269bd8240722c7f9d7974e#diff-0910ced16436543c1477e7a3528483b46612a86971ff771893e89700f85dfb3dR335 deprecation issue - https://github.com/checkstyle/checkstyle/issues/11507 We need to find some major version update time, and remove such methods from our API. We need to recheck...