upgrade to checkstyle 10.3.4

[romani]

https://checkstyle.org/releasenotes.html#Release_10.3.4

[famod]

@Calixte hasn't been committing anything to GH since May, which is a bit worrying. Is there anyone else working on thise repo? @Bananeweizen maybe?

[rnveach]

@Bananeweizen @Calixte Is there something stopping us finish the releases before doing more PRs, so we can atleast be at the same version as CS? I was hoping for eclipse-cs to be finished to upgrade sevntu and then distribute it among all the repos using it. https://github.com/sevntu-checkstyle/sevntu.checkstyle/issues/930

[Bananeweizen]

I didn't want to interfere with the work of @Calixte since he has done the upgrades quite nicely all the time.

I don't fully understand the relation between sevntu and eclipsecs maybe, but to my understand the sevntu code can be updated and upgraded right now without waiting. All the 10.x releases have been without breaking changes in the config XML, therefore any 10.x version of all the related tools should work together from that point of view. And the Java 11 requirement exists since 10.0 already. Or am I missing something else?

[rnveach]

sevntu and eclipsecs-sevntu are seen as one unit. https://github.com/sevntu-checkstyle/sevntu.checkstyle/blob/master/sevntu-checks/pom.xml#L18-L19

We cannot upgrade one without breaking the other, and it would double the release load for the small repo to release them separately now that it is like the way we are. So it may not make much sense, but sevntu relies on this repo for checkstyle upgrades.

I will wait for @Calixte to respond.

[Calixte]

Is there something stopping us finish the releases before doing more PRs, so we can at least be at the same version as CS?

Nope, we should be on the latest anytime soon.