Roman Ivanov

mvn clean spotbugs:check give no errors as it runs on classes, so add a warning to users that miss compile

7

steps: ``` $ git clone [email protected]:checkstyle/checkstyle.git $ cd checkstyle $ mvn clean spotbugs:check [INFO] Scanning for projects... [INFO] Inspecting build with total of 1 modules... [INFO] Installing Nexus Staging features:...

diff.groovy: improve clone time by depth=1

1

It is not big deal for CIs, it was a problem for me on hotspot, clone did not finish even for 10 minutes.... so I was not able to reuse...

https://github.com/checkstyle/checkstyle/commit/35e09408d068ab40aa31fd33b9589318d69970b9 This is example how builder generated content that violated line length validation and caused build failure Expected: wrap content to multiple lines as we do with issue titles

patch-diff-report-tool: should preserve stylesheet.css from jxr site

6

We do read sources generated by JXR. unfortunately tool does not copy it to `diff` folder, so sources become plain text. customization of css: ``` org.apache.maven.plugins maven-jxr-plugin ${jxr-plugin.version} ${project.basedir}/jxr.css **/.ci-temp/**/*...

Violations: https://teamcity.jetbrains.com/buildConfiguration/Checkstyle_ContributionIdeaInspectionsPullRequest/3854536?buildTab=Inspection Java/Abstraction issues ['public' method with 'boolean' parameter (Errors) (1)](https://teamcity.jetbrains.com/viewLog.html?tab=Inspection&buildId=3854536&embedded=true#) Java/Code maturity [Deprecated API usage (Errors) (1)](https://teamcity.jetbrains.com/viewLog.html?tab=Inspection&buildId=3854536&embedded=true#) [Use of System.out or System.err (Errors) (7)](https://teamcity.jetbrains.com/viewLog.html?tab=Inspection&buildId=3854536&embedded=true#) Java/JUnit [JUnit test method without...

update versions of some projects

9

I do not remember a reason why we use exact versions in projects-to-test-on.properties `elasticsearch|git|https://github.com/elastic/elasticsearch|v1.5.2||` Example: https://github.com/checkstyle/contribution/blob/master/checkstyle-tester/projects-to-test-on.properties#L22 right now it causing a problem that java files that are referenced in diff...

patch-diff-report-tool: make ability to show lines as yellow if changes is only in message

3

taken from https://github.com/checkstyle/checkstyle/pull/3774 Example: ``` Summary: Report id Files Unique rows Severity-warning base 890 1558 1558 patch 890 35 35 difference 272 1583 1583 ``` in this PR I expected...

restore rules - https://github.com/checkstyle/contribution/commit/596bcf37ee08b6231f189d5b653d076195df3bd5 fix code.

new Treewalker property to skip all nested Modules if there is parsing exception

21

It is our biggest limitation to not work on non compilable files https://checkstyle.org/writingchecks.html#Limitations > Code has to be compilable by javac to get valid violations. If it is not, you...

detected at https://github.com/checkstyle/checkstyle/pull/14117?notification_referrer_id=NT_kwDOAAxnuLE4Njc0Mzg0MTcxOjgxMjk4NA#issuecomment-1844198684 there should be no cycle in dependecy between IndentaitonCheck and its XxxxxHandler. In other words: There should be no public methods in IndentaitonCheck that some other class...