Results 160 issues of Roman Ivanov

create correct flles that are fully auto formatted and Checkstyle does not give any violation. we can copy existing Inputs and auto format, and all violations should be a defect...

approved
miscellaneous

We Should actually demand message to be always specified. (even Check has only one message) I more and more inclined to think that it will be better to have violation...

approved
miscellaneous
good second issue

> can you write bash block that find all Input file that are referenced in this script and make sure we have InputFormatted file for it ? or it is...

approved
miscellaneous

detected at https://github.com/checkstyle/checkstyle/pull/15452/files#r1705754697 We need to add support of verification of what violation was filtered. consider https://github.com/checkstyle/checkstyle/blob/master/src/test/resources/com/puppycrawl/tools/checkstyle/checks/whitespace/parenpad/InputParenPadTryWithResourcesAndSuppression.java#L17 ideally we should have violation message at line `try ( AutoCloseable a =...

https://checkstyle.org/checks/naming/illegalidentifiername.html#IllegalIdentifierName > Checks identifiers with a pattern for a set of illegal names, such as those that are restricted or contextual keywords. from https://github.com/checkstyle/checkstyle/issues/15105 and https://github.com/checkstyle/checkstyle/pull/15486#discussion_r1713058911 JLS Keywords as of...

we did not some to agreement to use google-java-format as embedded solution in maven build (as test dependecy and formatting before test execution) but we still need to keep specific...

approved
miscellaneous

detected at https://github.com/checkstyle/checkstyle/pull/15021 InputEqualsHashCodeEqualsParameter.java has wrong location of violation comments. https://github.com/checkstyle/checkstyle/blob/6d8f8f2f9064ab7706fd5c1dd5c715fe0b4ac599/src/test/resources/com/puppycrawl/tools/checkstyle/checks/coding/equalshashcode/InputEqualsHashCodeEqualsParameter.java#L15-L16 violation is actually only on method, not on class. Reason is wrong implementation of regexp to match comment wihtout...

approved
miscellaneous

Very initial introduction of new diff reporting workflow is done at https://github.com/checkstyle/checkstyle/pull/15235#issuecomment-2253466000 At the end of project, fill all possible gaps in documentation or onboarding of other maintainers to use...

It will be awesome to remove such empty `` tags. At least there is defenetely no text after it. https://google.github.io/styleguide/javaguide.html#s7.1.2-javadoc-paragraphs > Each paragraph except the first has `` immediately before...

content with tab: ``` public class Test { /** * The client's first name. * * @serialField serial String some test some testsome testsome testsome testsome testsome test * Path...