Rok Mihevc comments

Results 159 comments of


                                            Rok Mihevc

ARROW-17386: [R] strptime tests not robust across platforms

Thanks for the review @nealrichardson ! I've addressed your comments and I think this is ready for another review round.

ARROW-17386: [R] strptime tests not robust across platforms

CI issues don't seem related.

ARROW-17386: [R] strptime tests not robust across platforms

@jonkeane We only change the test here. Is the regression misattributed or are these tests used in tcph or ``?

ARROW-16695: [R][Python][C++] Extension types are not supported in joins

@michalursa I'd like to enable joining tables where some of non-key columns are ExtensionTypes. Am I right to assume this should be possible? Naive approach in this PR segfaults. Trying...

ARROW-16695: [R][Python][C++] Extension types are not supported in joins

I'm not sure who best to ask for review here. I'm approaching this very naively and am afraid I'm missing something.

ARROW-16695: [R][Python][C++] Extension types are not supported in joins

Thanks for the explanation @michalursa! That makes a lot of sense! @westonpace could I ask you or someone in vicinity to this code for review? :)

ARROW-16695: [R][Python][C++] Extension types are not supported in joins

Thanks for the review @westonpace! I've pushed proposed changes. Shall I merge if CI passes?

ARROW-16695: [R][Python][C++] Extension types are not supported in joins

Huh, [python and C++ on s390x get the physical type instead of extension](https://app.travis-ci.com/github/apache/arrow/jobs/580252967#L3789).

ARROW-16695: [R][Python][C++] Extension types are not supported in joins

Got it! I'll adapt HashJoin as well.

ARROW-16695: [R][Python][C++] Extension types are not supported in joins

@westonpace I had to introduce some changes to `RowEncoder` to get the `HashJoin` to work. Could you please confirm that I'm not doing something bad and I'll merge afterwards.