Rok Mihevc

Results 159 comments of Rok Mihevc

Just a short update: Arrow community is converging on a [fixed shape tensor extension array format](https://github.com/apache/arrow/pull/33925) and I have an [open PR](https://github.com/apache/arrow/pull/8510) to implement it in Arrow. Once that's done...

Thanks for the review @wgtmac! I've addressed some of it and will continue tomorrow. I'm still hitting an issue where `bit_writer_.PutZigZagVlqInt` (or other `bit_writer_.PutAligned`) work as expected when `-DCMAKE_BUILD_TYPE=Debug` but...

> Is that issue reproducible via the new test case? If true, I can dig into it later. I realised it was due to calling `DCHECK(bit_writer_.PutAligned(value, num_bytes))` instead of `bit_writer_.PutAligned(value,...

@wgtmac Thanks for the review. I addressed your comments. Outstanding items: FastDifferentialCoding & testing Put where `values.null_count() > 0`.

@wjones127 Thanks for the review! I've addressed the comments, please check if I missed something.