Rok Mihevc

icon indicating a website link rok.dev icon indicating an email [email protected]

icon company Freelance icon location Amsterdam, Netherlands icon location Started as a Physicist. Open source contributor. Interested in data science and data tooling.

Results 159 comments of Rok Mihevc

ARROW-17619: [C++][Parquet] Add DELTA_BYTE_ARRAY encoder to Parquet writer

note: this should support BYTE_ARRAY and FIXED_LEN_BYTE_ARRAY. [PARQUET-2231](https://issues.apache.org/jira/browse/PARQUET-2231)

ARROW-17619: [C++][Parquet] Add DELTA_BYTE_ARRAY encoder to Parquet writer

> Seems the skeleton look great now. I think we can extract `Put` because now we have 4 `Put(...)` implemention now... Will do first thing tomorrow!

ARROW-17619: [C++][Parquet] Add DELTA_BYTE_ARRAY encoder to Parquet writer

@mapleFU I've refactored to templates. Could you please do another pass?

ARROW-17619: [C++][Parquet] Add DELTA_BYTE_ARRAY encoder to Parquet writer

Thanks for @mapleFU. I used your suggestion.

ARROW-17619: [C++][Parquet] Add DELTA_BYTE_ARRAY encoder to Parquet writer

Thanks for the review @wgtmac !

ARROW-17619: [C++][Parquet] Add DELTA_BYTE_ARRAY encoder to Parquet writer

If there are no objections I'd like to merge this before 12.0.0 window closes tomorrow (Tuesday).

ARROW-17619: [C++][Parquet] Add DELTA_BYTE_ARRAY encoder to Parquet writer

Thanks for the review @mapleFU! If CI passes and there's no further comments I'll merge.

ARROW-17619: [C++][Parquet] Add DELTA_BYTE_ARRAY encoder to Parquet writer

@pitrou do you mean you would prefer this is merged immediately after the 12.0.0 window so we have until 13.0.0 to observe for bugs? Or you mean we need another...

ARROW-17619: [C++][Parquet] Add DELTA_BYTE_ARRAY encoder to Parquet writer

Do we need another review here?

ARROW-17619: [C++][Parquet] Add DELTA_BYTE_ARRAY encoder to Parquet writer

@pitrou I believe I need to finish the random array generator. I got sidetracked on a construction project and I'll try to finish this by end of the week.