arrow
arrow copied to clipboard
ARROW-17386: [R] strptime tests not robust across platforms
This is to resolve ARROW-17386.
https://issues.apache.org/jira/browse/ARROW-17386
You may want to export arrow::internal::kStrptimeSupportsZone
as a public API and use it: https://github.com/apache/arrow/blob/master/cpp/src/arrow/util/value_parsing.h#L774
You may want to export
arrow::internal::kStrptimeSupportsZone
as a public API and use it: https://github.com/apache/arrow/blob/master/cpp/src/arrow/util/value_parsing.h#L774
That's a good point! However lubridate's strptime supports %Z
flag for strftime only (see docs), so I don't think we need kStrptimeSupportsZone
for this change. I opened ARROW-17398 to not lose the idea.
Thanks for the review @nealrichardson ! I've addressed your comments and I think this is ready for another review round.
CI issues don't seem related.
Benchmark runs are scheduled for baseline = 6c675c35349a066c52758dac09e7b08fd990d239 and contender = 4ae26d1bb7537ca19d3b925cf4e7bf5f6a1c0d07. 4ae26d1bb7537ca19d3b925cf4e7bf5f6a1c0d07 is a master commit associated with this PR. Results will be available as each benchmark for each run completes.
Conbench compare runs links:
[Finished :arrow_down:0.0% :arrow_up:0.0%] ec2-t3-xlarge-us-east-2
[Finished :arrow_down:0.41% :arrow_up:0.07%] test-mac-arm
[Failed :arrow_down:0.56% :arrow_up:0.0%] ursa-i9-9960x
[Finished :arrow_down:0.07% :arrow_up:0.04%] ursa-thinkcentre-m75q
Buildkite builds:
[Finished] 4ae26d1b
ec2-t3-xlarge-us-east-2
[Finished] 4ae26d1b
test-mac-arm
[Failed] 4ae26d1b
ursa-i9-9960x
[Finished] 4ae26d1b
ursa-thinkcentre-m75q
[Finished] 6c675c35
ec2-t3-xlarge-us-east-2
[Finished] 6c675c35
test-mac-arm
[Failed] 6c675c35
ursa-i9-9960x
[Finished] 6c675c35
ursa-thinkcentre-m75q
Supported benchmarks:
ec2-t3-xlarge-us-east-2: Supported benchmark langs: Python, R. Runs only benchmarks with cloud = True
test-mac-arm: Supported benchmark langs: C++, Python, R
ursa-i9-9960x: Supported benchmark langs: Python, R, JavaScript
ursa-thinkcentre-m75q: Supported benchmark langs: C++, Java
['Python', 'R'] benchmarks have high level of regressions. ursa-i9-9960x
@jonkeane We only change the test here. Is the regression misattributed or are these tests used in tcph or <insert third option>
?