Rok Mihevc comments

Results 159 comments of


                                            Rok Mihevc

ARROW-17798: [C++][Parquet] Add DELTA_BINARY_PACKED encoder to Parquet writer

I've opened [ARROW-18365](https://issues.apache.org/jira/browse/ARROW-18365) to follow up on FastDifferentialCoding suggestion. @pitrou could you please do a final pass here?

ARROW-17798: [C++][Parquet] Add DELTA_BINARY_PACKED encoder to Parquet writer

Tests are now passing for `int64`. I've also done some minor changes and switched away from `SafeSignedSubtract`. @pitrou could you please do another pass?

ARROW-17798: [C++][Parquet] Add DELTA_BINARY_PACKED encoder to Parquet writer

@pitrou CI passes, so I think this is ready for another look.

ARROW-17798: [C++][Parquet] Add DELTA_BINARY_PACKED encoder to Parquet writer

@pitrou I think I addressed everything, please take a look if it makes sense.

ARROW-17798: [C++][Parquet] Add DELTA_BINARY_PACKED encoder to Parquet writer

> Unfortunately it seems C++ builds are broken currently - [#14292 (comment)](https://github.com/apache/arrow/pull/14292#issuecomment-1351548379) I've not rebased in a while so I'm confused as to how this is happening.

ARROW-17798: [C++][Parquet] Add DELTA_BINARY_PACKED encoder to Parquet writer

> Github is implicitly merging from master when running CI jobs AFAIU? Whoa, that was not my expectation.

ARROW-17798: [C++][Parquet] Add DELTA_BINARY_PACKED encoder to Parquet writer

Thanks for all the reviews @pitrou & others :)

ARROW-17933: [C++] SparseCOOTensor raises error when created with zero elements

@pitrou is there something left to address here?

ARROW-17933: [C++] SparseCOOTensor raises error when created with zero elements

This is waiting for review.

ARROW-17933: [C++] SparseCOOTensor raises error when created with zero elements

I was waiting for @pitrou. I suppose @AlenkaF, @westonpace or @jorisvandenbossche would be good candidates.