robtfm

Results 126 comments of robtfm

does it have any impact on time? i think optimizing out individual string allocations is almost certainly not worthwhile. the extra code complexity is quite minor though, if it was...

Could you share a reproduction of the issue? Missing imports should be handled already.

ok thanks, i reproduced it. i think the problem here reduces down to ```rs #ifdef USE_A #import a::b #endif fn main() -> u32 { return b::C; } ``` for this,...

after thinking about it a bit i think while contextually resolving the required imports would be better, it's not easy. it would require - capturing the def-state of each import...

draft as needs BorderRadius added edit: actually I guess it isn’t necessary to support in this pr. It could/should be added in future but doesn’t stop the current functionality from...

@viridia iirc you requested this originally. if you're not interested i think this pr is going to be stuck in limbo so i may as well close it (i'm using...

in case it's unclear from the tests, the way to do that would be `app.add_plugins(HierarchyPropagationPlugin::::default());` then `commands.entity(gltf_root).insert(Propagate(your_renderlayer));`. it would have no effect on entities in other parts of the scene,...

I’ll see if I can do 3 over the weekend, and try and have a look at 4 as well

i couldn't see much scope to remove trait bounds (just testing by trial and error), i removed them from `PropagateStop` and `PropagateOver` only. if there's something in particular that looks...

i get crashes on exit from `egui_context.ctx_mut()`, can we change them to `let Some(ctx) = egui_contexts.try_ctx_mut() else { return; }` please