bevy-console icon indicating copy to clipboard operation
bevy-console copied to clipboard

Update to Bevy 0.14

Open msklosak opened this issue 1 year ago • 3 comments
trafficstars

This PR updates bevy-console to Bevy 0.14, bumping the version to 0.12.0.

Fixes #69

msklosak avatar Jul 06 '24 00:07 msklosak

I decided to try this PR myself. It was pretty much a drop-in replacement with no modifications needed. The only oddity is that for some reason my terminal is now transparent... image

I haven't had a chance to check yet but I suspect Color32 is either not being constructed correctly or there's a bug in egui. https://github.com/RichoDemus/bevy-console/blob/main/src/console.rs#L256

IamTheCarl avatar Jul 17 '24 23:07 IamTheCarl

Works for me as well

TarekAS avatar Aug 10 '24 12:08 TarekAS

i get crashes on exit from egui_context.ctx_mut(), can we change them to let Some(ctx) = egui_contexts.try_ctx_mut() else { return; } please

robtfm avatar Aug 13 '24 16:08 robtfm

Awesome work, thanks a lot! I'll merge and address the issues after

makspll avatar Sep 03 '24 19:09 makspll

Hmm, @IamTheCarl Which version of bevy_console were you using previously, we've had a PR which added customisation options and it seems the default color is indeed transparent:

Color32::from_black_alpha(102),

makspll avatar Sep 03 '24 21:09 makspll