Rob Shakir

Results 387 comments of Rob Shakir

Per the comment that was in the description of this leaf, at some point we had considered having the ability to support queues that are implicitly created by the system...

You cannot have a leafref from a `config true` leaf to a `config false` one -- and equally, this isn't a great idea because it means that to validate leafrefs...

> Please let me know what you think: One idea that comes to mind is we could create a new leaf list for system created qos queues. This would help...

If this is the case, then we need implementations to create an entry in the `/qos/queues/queue` list for all system-defined queues. This is akin to how all interfaces are created...

Hi Bijoy, Thanks for the issue - I agree that there are some elements of this module that need to be brought in-line with the OpenConfig style guide. We'll start...

I don't think that this is reflected in the FIB. The FIB will show the installed forwarding entries that there are, including characteristics such as the L2 encapsulation that might...

Within the same `Subscription` RPC, this does seem like an error -- either the client wanted `ON_CHANGE` or it wanted `SAMPLE`. If it wants both it can make two RPC...

> Of course the client can open two parallel RPCs to retrieve the same data, but is there a reason to force that behavior? Is there a reason to force...

> >Is there a reason to force the complexity of having to deal with this? > > I wouldn't necessarily agree about the complexity part: if we simply treat a...

It looks like this might be something that overlaps with the reworked structure in https://github.com/openconfig/gribi/pull/93 -- could you PTAL, it might allow you to remove the augment that you have...