Rob Scott

Results 311 comments of Rob Scott

To clarify here, the only reason both a class field and annotation should exist on an Ingress resource at the same time would be part of an upgrade from one...

@maxsmythe Thanks for the great feedback here! Completely understand if it takes some time to figure out if/where this belongs. We don't mind hosting this in our repo as well,...

Thanks for following up on this @maxsmythe! It looks like this needs a rebase + an update to our latest API version, but otherwise it would still be accurate.

I agree that both of the things you're describing are necessary and related. We should probably track both of these here or create a separate issue for the test @mikemorris...

As I understand it, Ingress was never intended to be used to forward to Service of type ExternalName, but unfortunately that never made it to the spec. I think the...

I really like @carlisia's idea in #1336. @abhijit-dev82 do you think you could incorporate that restructuring into this PR? /ok-to-test

Thanks for all the work on this @aryan9600! We talked about this at today's community meeting. I left some follow up comments above, but I think the major themes are:...

Thanks @aryan9600! This LGTM but will defer to someone else for the final approval. /approve