gateway-api icon indicating copy to clipboard operation
gateway-api copied to clipboard

Published 20 hours ago • verified publisher icon kubernetes-sigs

add GEP-1323: Response Header Filter

Open aryan9600 opened this issue 1 year ago • 2 comments

Signed-off-by: Sanskar Jaiswal [email protected]

What type of PR is this? /kind gep

What this PR does / why we need it: Adds a GEP proposing a way of modifying response headers via a new field responseHeaderModifier.

Which issue(s) this PR fixes:

Fixes #1323

Does this PR introduce a user-facing change?:

NONE

aryan9600 avatar Aug 15 '22 15:08 aryan9600

Hi @aryan9600. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

k8s-ci-robot avatar Aug 15 '22 15:08 k8s-ci-robot

Thanks for all the work on this @aryan9600! We talked about this at today's community meeting. I left some follow up comments above, but I think the major themes are:

  1. This GEP feels very close to ready to merge.
  2. When it comes to variables in header names, we should mention that some underlying implementations like Envoy support interpolating variables into header values, but that is unlikely to be portable across implementations.
  3. When it comes to policy attachment, we should mention it as a possible future extension point, but we don't need to cover it in detail in this GEP.

/ok-to-test

robscott avatar Aug 30 '22 01:08 robscott

Thanks @aryan9600! This LGTM but will defer to someone else for the final approval.

/approve

robscott avatar Aug 30 '22 05:08 robscott

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: aryan9600, robscott

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment Approvers can cancel approval by writing /approve cancel in a comment

k8s-ci-robot avatar Aug 30 '22 05:08 k8s-ci-robot

Yup, I think this is good to go.

/lgtm

youngnick avatar Sep 01 '22 03:09 youngnick