Rob Scott

Results 480 comments of Rob Scott

Thanks for raising this issue @hoerup! When discussing this in relation to GEP #735, one of the questions we had was where this configuration should belong (more in #1127). Is...

@skriss that's a great question. I think it will be most straightforward to start with Gateways being defined by the tests directly. We'll need to discuss more broadly though, maybe...

@skriss are there any specific tests from this list you want to start on?

Thanks for raising this issue @yangminzhu! It's very helpful to see how other systems are supporting this kind of capability. I think I'd personally prefer to avoid overloading header matching...

Update: We are working on this. @youngnick updated the build script and we released v0.4.2 to test it out, unfortunately not quite working yet: https://prow.k8s.io/view/gs/kubernetes-jenkins/logs/post-gateway-api-push-images/1503442368546738176 /lifecycle frozen

The [namespace validation included in the CRDs](https://github.com/kubernetes-sigs/gateway-api/blob/master/apis/v1beta1/shared_types.go#L413) should prevent empty string from being a valid input. I think the options are effectively nil or a 1+ character string. We should...

>So if we want to handle nil and "" as equivalent, why not have a string with "omitempty" behavior instead of the *string and reduce the number of cases that...

>@shaneutt : No, "" shouldn't be allowed as a namespace value, let's not do that. >@robscott : We have to handle "", it should do the same thing for nil...