Rob Ede

Results 360 comments of Rob Ede

I left some comments earlier. See the PR.

There's certainly some tension here between the permissiveness of actix-multipart when it comes to multipart content other than form-data and an easy-to-use API for the common case. Lemme have a...

Hey, thanks for the issue. I'd be useful to get a trimmed down reproduction of your problem here. I suspect I know what's going on but it's gonna be hard...

The solution to this issue should allow user customization of the excluded mime types.

Use of a predicate function is a good idea imo. Then we just set the default to ignore images to solve #2981.

@cptrodolfox I spent some time working on this PR today but I can't push to your branch. Can you check [the settings](https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/working-with-forks/allowing-changes-to-a-pull-request-branch-created-from-a-fork#enabling-repository-maintainer-permissions-on-existing-pull-requests) for this PR? Alternatively, apply this patch here:...

The advantage over taking a function pointer is that you can still avoid the generic param and also pass closures as well.

Should be noted that some auto traits are lost in this PR, wondering if this is okay. https://github.com/actix/actix-web/actions/runs/4662131547/jobs/8252158730?pr=2996#step:6:410 ``` Removed items from the public API ================================= -impl core::marker::Send for actix_web::middleware::Compress...

From the rebase this needs a rustfmt run. On the blocker for merging this, I'd be willing to give up the UnwindSafe impls but not so much Send and Sync,...

I've created #3075 with the subset of changes that do not cause breakage to the public API.