Rob Ede comments

Results 360 comments of


                                            Rob Ede

Improve streaming interface

We're experimenting in [the lab](https://crates.io/crates/actix-web-lab) with some APIs to make streaming responses easier and off-thread compatible. - https://docs.rs/actix-web-lab/latest/actix_web_lab/body/fn.channel.html - https://docs.rs/actix-web-lab/latest/actix_web_lab/body/fn.writer.html

fix: set error to Payload before dispatcher disconnect

I'm apprehensive to accept PRs like this without a test case that fails before the patch.

Does actix-web-codegen support attribute macros to GUARD of cusomized definition ??

Can you give me an example of the code you want to write?

chore: update http crate

I'm curious if you have any particular motive to get this merged. From my PoV, the Actix Web project doesn't have any real _need_ to do it.

chore: update http crate

Context for that particular change: https://github.com/actix/actix-net/pull/508

build(deps): update env_logger requirement from 0.10 to 0.11

@dependabot rebase

build(deps): update env_logger requirement from 0.10 to 0.11

@dependabot rebase

ci: check semver on labelling PRs

Hmm... this random idea worked out well. It's a kind of interesting technique. @JohnTitor you might be interested in this for other projects?

ci: check semver on labelling PRs

Actually I should do some negative tests before we adopt this. And address amendments to a PR being able to run the same job without needing to re-label it.

actix-web doesn't compile with rustls 0.23.1

Yea the rustls story is getting more complicated with the additional backends they're adding; not quite sure how to support them nicely yet.