Rob Ede comments

Results 360 comments of


                                            Rob Ede

add MPTCP socket protocol (optional)

Thanks for pushing this. My tweaks are mostly mechanical. We're expecting Windows CI failures atm so no worries there.

breaking change made in minor version

Rust libraries typically avoid this conflict between a desire to add options and breaking changes by employing the builder pattern. My suggestion is that the `RunnerOptions` struct be deprecated externally...

breaking change made in minor version

Fair, I do believe there have been breaks before. The thing is, you'll find most Cargo users are very much used to and expect crate authors to respect semver if...

Streaming encoder

@NobodyXu since this is additive, I propose we review this after the 0.4.0 release ?

flush data still available in the decoder when no input (#123)

sorry for the (mega) delay, hope this can get into the release

support bytemuck

Would `#[cfg_attr(not(feature = "bytemuck), forbid(unsafe))]` work?

support bytemuck

Signalling forbid is important for consumers who run cargo-geiger and have no need of the bytemuck integration.

please update rustls example to 0.22.0

this is a non-trivial task since actix-tls and actix-web will need to have rustls v0.22 support added first

Please add caching example

PR welcome where comments on specifics can be made.

Add an example returning HttpResponse from middleware.

You need to add this example to the root workspace Cargo.toml in order to make sure it's tested in CI.