Rob Ede

Results 360 comments of Rob Ede

So the benefit of `regex` over `regex-lite` is it's unicode support so I think what I'd prefer is a feature flag called `unicode` (bikeshedding tbd), enabled by default, where disabling...

> prioritizes smaller binary sizes and shorter Rust compile times over performance Another good reason to have this be an on-by-default feature since this will be sort of "infectious" as...

I've made some changes to isolate the conditional Regex logic (for actix-router at least) in a separate module which also allows us to keep using `regex::RegexSet` for better perf.

I really appreciate your work on this feature. As it happens I'm actually working on this at the lower level with the ambition to introduce a generic stream wrapper as...

I can probably clean it up as-is. I remember leaving it unfinished in terms of the PP2 extensions but it's likely that an MVP will be useful for most people.

> The main TLV is the authority This is great info. I actually don't have significant practical experience using PROXY yet.

Yea for sure. I have a medium term need for it at work for exactly that reason.

You can look inside the `actix-web-codegen` crate source. I'd recommend adding a trybuild test first using the format mentioned in the OP issue and discussion post.

Good point. The trybuild tests only run on our MSRV. So Rust 1.72.

@sabinonweb Do you want to open a draft PR so I can see where you've gotten to?