Robert Korulczyk
Robert Korulczyk
> UnqueryableQueryMock throw an exception independently from emulateExecution. Yes, and that is the problem.
The purpose of this mock is to ensure that no actual query will be performed. With `emulateExecution` there will be not actual query, there should be no exception in this...
@FabrizioCaldarelli I don't get your point. These changes are correct, the tests should be fixed to not throw exception when there is no need for it. It was already done...
Why would you want add additional conditions to (correct) code instead of fixing (incorrect) tests? It is actually a bug that ``UnqueryableQueryMock`` throws exception for query with ``emulateExecution``, it should...
Thats because `findAll()` works in the same way as `find()` - the key-word here is "find" not "all".
AFAIK you can use expression as field value in `update*` methods. So this is basically duplicate of https://github.com/yiisoft/yii2/issues/12781 - if we add support for `case` expressions, you could use it...
I believe this is a bug with respecting privileges, there is a PR to fix this: https://github.com/FriendsOfFlarum/gamification/pull/102
> db (via doctrine so not a good fit for Yii) I'm not sure how redis driver is different than db in this case - Yii has its own redis...
IMO it makes more sense to remove `if (PHP_VERSION_ID >= 80000)` condition completely, as currently both branches of this if are effectively the same.
@samdark I don't think that this needs a changelog entry, as this does not change behavior at all. It is just a code simplification.