Robert Korulczyk

Results 275 comments of Robert Korulczyk

> Can you formulate what guarantee engine currently provides with regard of unsetting or not unsetting relations? I think that general rule of thumb is: if you rely on magic...

There are still things that could be improved in current solution: 1. We could make `setRelationDependencies()` protected instead of private, so users could disable or control this behavior in their...

> It's not the EXAMPLES that contradict each other - it's the ENGINE BEHAVIOUR in them. In example 2 you complain that relations loaded with `populateRelation()` **are not** refreshed. In...

`@property` annotations are generated by release script, so this changes may be overwritten.

It generates `@property` tags based on available getters and setters, so they're in sync.

I'm not sure about this feature overall, but I definitely don't like current signature. Making `$end` nullable only make sense if passing `$end` is optional. Explicitly passing `null` as third...

I also think that using `instanceof UnitEnum` would be better - it should be safer than changing behavior for all objects. And IMO it should be done at the beginning...

https://github.com/yiisoft/yii2/pull/17346#issuecomment-532758630

> If you have some kind of check with `can` with different params for every call this will blow up your cache. Memory usage is not that bad if we...

> My concern was, if someone has ie. `{'timestamp': 1684138273459}` (current time with ms) as params, it will create a huge amount of useless entries in no time. I would...