Robert Korulczyk

Piwik uses transactions on bulk processing, so lock is released after whole transaction is committed. When one process locks one row in `bot_db` table, and second process locks another row...

> Easier to use when nonce is generated at webserver level: No configuration required as the nonce is automatically read from the header. Are you sure about that? AFAIK if...

> The performance difference between using cache and not using cache is about 15 times, Do you have an actual benchmark? What is so slow in this method that would...

> Using cache does not require additional checks and judgments Cache has its own overhead, it is not always worth to cache some calculation, sometimes retrieving cached value is slower...

By default `Logger::flush()` does not flush all messages from memory - it only dispatches messages from logger to log targets (that will keep these messages in memory). You need to...

`asDuration()` does not accept float according to phpdoc.

I would rather treat this as user error - if you pass float to method that does not accept float, then it is your fault, not framework. On the other...

This should not be fixed in `BaseHtml`. You just need a validator, that casts user input to string/array. Personally I'm using something like ```php public function rules() { return [...

Note that this syntax is planned to be deprecated in MySQL: > As of MySQL 8.0.20, the server supports the index-level optimizer hints [JOIN_INDEX](https://dev.mysql.com/doc/refman/8.0/en/optimizer-hints.html#optimizer-hints-index-level), [GROUP_INDEX](https://dev.mysql.com/doc/refman/8.0/en/optimizer-hints.html#optimizer-hints-index-level), [ORDER_INDEX](https://dev.mysql.com/doc/refman/8.0/en/optimizer-hints.html#optimizer-hints-index-level), and [INDEX](https://dev.mysql.com/doc/refman/8.0/en/optimizer-hints.html#optimizer-hints-index-level), which are...

I think that most critics can be summarized "in some cases it does not work", and removing this feature would change it to "it never works", which is not an...