Robert Korulczyk

Results 275 comments of Robert Korulczyk

This will break `getDirtyAttributes()` and `isAttributeChanged()` behavior - `===` will return `false` if you compare 2 cloned object (even if they're identical).

> I think we should introduce `isEqual` method Related: #5375

I don't like this `isEqual()` method. It looks over-complicated and bugged (`Expression` may hold params, which are ignored on casting to string). All we need is to compare object properties...

Because it will use `==` also for comparing properties, while we need to use `===` in this case.

I was thinking about something like: ```php public function isAttributeChanged($name, $identical = true) { if (isset($this->_attributes[$name], $this->_oldAttributes[$name])) { if ($identical) { if (is_object($this->_attributes[$name]) && is_object($this->_oldAttributes[$name])) { return !( $this->_attributes[$name] ==...