queue icon indicating copy to clipboard operation
queue copied to clipboard

Create additional packages for drivers

Open machour opened this issue 5 years ago • 15 comments

https://forum.yiiframework.com/t/additional-packages-for-specific-drivers-storages/125718/2

  • amqp_interop
  • beanstalk
  • db
  • file
  • gearman
  • redis
  • sqs
  • sync

machour avatar Apr 17 '19 10:04 machour

I wonder if we need non-amqp_interop drivers...

samdark avatar Apr 17 '19 10:04 samdark

@zhuravljov what do you think?

samdark avatar Apr 17 '19 11:04 samdark

What's currently covered by amqp_interop:

  • beanstalk
  • sqs
  • redis
  • gearman
  • file
  • db (via doctrine so not a good fit for Yii)

That leaves us with:

  • amqp_interop
  • sync (could be part of the library itself)
  • db

samdark avatar Apr 18 '19 11:04 samdark

Agreed, sync belongs in yiisoft/yii-queue. Having db & amqp-interop as drivers sounds good for a start.

machour avatar Apr 18 '19 11:04 machour

https://github.com/yiisoft/yii-queue-interop

I don't think we need to create DB driver at this point. We can add it later.

samdark avatar Apr 18 '19 12:04 samdark

How about the debug & gii modules of yiisoft/yii-queue?

Does these also separate into different packages such as yiisoft/yii-debug-queue and yiisoft/yii-gii-queue?

larryli avatar May 06 '19 08:05 larryli

Same things goes for db-redis for example which currently embeds:

  • debug
  • rbac
  • i18n
  • gii

@samdark how would we handle these & the case mentioned by @larryli ? Ideally we need to split those in order to have minimalistic requirements in composer.json, but I'm afraid we'll end up with a zillion packages to maintain.

machour avatar May 06 '19 10:05 machour

db (via doctrine so not a good fit for Yii)

I'm not sure how redis driver is different than db in this case - Yii has its own redis extension with own connection - reusing it should be preferred over whatever amqp_interop uses.

rob006 avatar May 06 '19 15:05 rob006

We also need to take care of porting the stomp driver

machour avatar Jun 11 '19 12:06 machour

https://github.com/yiisoft/yii-queue-interop

I don't think we need to create DB driver at this point. We can add it later.

Hi @samdark , do you not think we should actually do DB driver first, reason I say so is barrier to entry, most people have LAMP or WAMP, so without installing anything else they should be use yiisoft/queue. What do you think?

aphraoh avatar Mar 22 '24 00:03 aphraoh

Could be done, yes. yiisoft/db is released so no obstacles. Do you want to handle it?

samdark avatar Mar 22 '24 07:03 samdark

Could be done, yes. yiisoft/db is released so no obstacles. Do you want to handle it?

DbAdapter.zip

Done! Would like to add it in the same folder that SynchronousAdapter.php is. Confirm this is OK? NOTE: This will be my first check into Github, so a bit nervous! Will then raise a few issue to fix the TODO in the file.

aphraoh avatar Mar 24 '24 18:03 aphraoh

No, that should be separate repository.

samdark avatar Mar 24 '24 21:03 samdark

No, that should be separate repository.

Alexander, that is fine but like I said I have never checked anything into Github, maybe you can help me by creating an empty repository, maybe we can call it yiisoft/queue-db, and I can take it from there!?...

aphraoh avatar Mar 24 '24 22:03 aphraoh

@aphraoh https://github.com/yiisoft/queue-db

vjik avatar Mar 25 '24 13:03 vjik