Roman Mohr

Results 229 comments of Roman Mohr

@igrigorik @annafil thank you for clarifying this. I for instance wanted to analyze purely via the archives how many reviews happend on PRs, if they got approved, changes were requested,...

/cherry-pick release-0.55

quickly checked if something is wrong with the PR: checking the pr job history, the code looks good. /retest

/approve separation makes sense and looks good from quick glance. Happy if someone else can review.

@zhhray can you verify that other pods can reach the internet, and in addition, can you try connecting to the vm via `virtctl console` (serial console) or `virtctl vnc` (remote...

@davidvossel @acardace do you plan to continue the work on this PR?

@xpivarc happy if you follow up on the detailed code review like you already do.

It could be related to safepath, however I am not sure. It looks exactly like what I tried to fix here: https://github.com/kubevirt/kubevirt/pull/8098 (and did not do correctly). This was before...

@RamLavi could you describe the background of this change? Like why does the virt-launcher pod need this info and not for instance the VMI status?